Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and cleanup process_attestation #783

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Simplify and cleanup process_attestation #783

merged 3 commits into from
Mar 19, 2019

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented Mar 15, 2019 •
edited by djrtwo

Fix #753.
No substantive changes within the context of phase 0.

  • Significantly improve readability.
  • Significantly reduce line count.
  • Improve testability by avoiding untriggerable assert related to phase 1 functionality.

@JustinDrake
Simplify and cleanup process_attestation
96ab535 
Improve readability and testability (by avoiding untriggerable `assert`). Fix #753.
@JustinDrake
Update 0_beacon-chain.md
d8d653d
@JustinDrake JustinDrake added the general:presentation Presentation (as opposed to content) label Mar 15, 2019
vbuterin
vbuterin approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@vbuterin vbuterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djrtwo
Copy link
Contributor

djrtwo commented Mar 19, 2019

To clarify, this has no substantive changes, correct?

@djrtwo
Copy link
Contributor

djrtwo commented Mar 19, 2019

and what is the untriggerable assert?

@JustinDrake
Copy link
Collaborator Author

To clarify, this has no substantive changes, correct?

Correct :) (Hence the "presentation" tag.)

what is the untriggerable assert?

It's assert get_bitfield_bit(attestation.custody_bitfield, i) == 0b0.

@djrtwo djrtwo merged commit 4111797 into dev Mar 19, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-11 branch March 19, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuterin vbuterin vbuterin approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JustinDrake @djrtwo @vbuterin