Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Eth1Data voting #938

Merged
merged 9 commits into from
Apr 17, 2019
Merged

Simplify Eth1Data voting #938

merged 9 commits into from
Apr 17, 2019

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented Apr 16, 2019 •
edited
Loading

  • Remove Eth1DataVote object and simplify logic throughout. 29 lines removed 馃帀
  • Reduce voting latency by counting votes per block 馃帀
  • Reduce worst-case beacon state overhead

vbuterin
vbuterin approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@vbuterin vbuterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@JustinDrake JustinDrake merged commit 57e5409 into dev Apr 17, 2019
@hwwhww hwwhww deleted the JustinDrake-patch-13 branch May 9, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuterin vbuterin vbuterin approved these changes

Assignees
No one assigned
Labels
general:simplification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustinDrake @vbuterin