Upgrade template #228
Merged
Upgrade template #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update template
See an example issue here: ethereum#150
Show full explanation for pydocstyle failures
* Add breaking change type to newsfragment * Move breaking-change -> breaking
Frankly not sure why recursive-exclude doesn't work here, but prune does, and that's good enough for me now. It's also probably preferable to only exclude venv* at the root, anyway.
Use updated CircleCI images
Exclude huge and unnecessary venv*/ from dist
Upgrade towncrier to fix the duplicate title bug
It can get big with installed libraries. On a relatively small release of eth-portal, this one change cut the .tar.gz release size from 574Kb to 14Kb.
Don't push .tox file to tar.gz release
* Tweaks to release process * Drop python 3.6
toxinidir won't mean anything in a Makefile
Upgrade isort
- Clean up github PR template to remove double links to the newsfragment README.md - Clean up some typos and make some minor refactors.
- It is not recommended to invoke ``setup.py`` directly, instead opting for ``python -m build`` for the commands in this commit (see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html) - Add newsfragment for ethereum#70
Do not invoke `setup.py` directly; minor refactor + cleanup
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
* template cleanup following initial merge with py-evm * add flake8 pin comment * correct license years * add pin note to mypy
…m#81) * apply template updates found following merge with eth-typing * add build as a dev dependency * remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep
* add updates found when merging template with py-ssz and eth-abi * add wheel and wheel-windows to ci and reorg
pacrob
force-pushed
the
upgrade-template
branch
from
b0b3530
to
5135385
Compare
pacrob
force-pushed
the
upgrade-template
branch
7 times, most recently
from
cad0622
to
50673ca
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
50673ca
to
edfb466
Compare
kclowes
approved these changes
Apr 28, 2023
| pip install -e ".[dev]" | ||
| ``` | ||
|
|
||
| To run the integration test cases, you need to install node and the custom cli tool as follows: |
There was a problem hiding this comment.
I'd like to keep this integration testing documentation around somewhere. eth-account does fuzz testing against ethers for hdaccounts and I reference this periodically.
There was a problem hiding this comment.
Yup, that's my oversight. Added back.
| @@ -86,6 +86,7 @@ def signTransaction(self, transaction_dict): | |||
| warnings.warn( | |||
| "signTransaction is deprecated in favor of sign_transaction", | |||
| category=DeprecationWarning, | |||
| stacklevel=2, | |||
There was a problem hiding this comment.
I'm curious about this change - is it a flake8-bugbear catch?
There was a problem hiding this comment.
It is flake8-bugbear. The full error was:
B028 No explicit stacklevel keyword argument found.
The warn method from the warnings module uses a stacklevel of 1 by default.
This will only show a stack trace for the line on which the warn method is called.
It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
It sounded reasonable to me so just added the stacklevel arg.
There was a problem hiding this comment.
Yep, makes sense to me! Thanks!
| ], | ||
| python_requires=">=3.6, <4", | ||
| python_requires=">=3.7, <4", |
There was a problem hiding this comment.
This is a breaking change. I'm okay with including it, but let's make sure that we highlight in the release notes.
There was a problem hiding this comment.
added a breaking newsfragment
…fragment for drop py36 from setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The project template has been updated, this pulls in those changes.
To-Do
Cute Animal Picture