Ledger wallet support #34
Conversation
The function defunctSignMessage() is not working but is added for documentation purpose.
- remove ledgerblue dependency - pack all device comm in LedgerUsbDevice class
- use checksumed address - return r and s as int - Add instruction for ledger init using a well defined seed - add ledger as a sessions fixture - add tx_signed and addresses values related to the new seed - update tests to use new defined seed
|
Hi, this feature (ledger support) is very useful. Is there a plan to review and merge this? cc @pipermerriam @bargst |
|
cc @kclowes |
|
No plan yet, but it keeps coming up so I think it may make sense to have it be the next big thing to tackle after async. I know @davesque spent some time digging in here too, but I'm not sure where he landed. |
|
I was looking at HD wallet support which is a separate thing. |
|
+1 it would be great to see that support. |
|
It might be handy for testing purposes to use the SpeculOS simulator: https://github.com/LedgerHQ/speculos |
|
good idea! I started the upgrade to latest eth-account, will see if I could add SpeculOS testing |
|
I've been trying out this excellent library with web3py integration as a signing middleware: Would be really, really, really awesome to have this finally supported as a production feature. |
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
Merging this work by @bargst into a local feature branch to put it on ice until we can dig into it later this year.