Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LedgerAccount type #25

Open
pipermerriam opened this issue Jun 4, 2018 · 7 comments
Open

Create LedgerAccount type #25

pipermerriam opened this issue Jun 4, 2018 · 7 comments

Comments

@pipermerriam
Copy link
Member

What is wrong

Hardware wallets are great!

How can they be implemented.

https://gist.github.com/bargst/5f896e4a5984593d43f1b4eb66f79d68

This appears to be a great starting point.

The base Account object should probably assume the default path. We should probably also expose an API for accessing sub-accounts at a different path assuming the ledger supports arbitrary BIP32 paths.

@pipermerriam
Copy link
Member Author

Probably not a blocker but: #24 is likely related to this in some way since both leverage HD wallets in some form.

@bargst
Copy link

bargst commented Sep 27, 2018

Some work merged in a local feature branch in #34 pending in-depth review and security audit.

@pipermerriam
Copy link
Member Author

Alternate implementation from the shadowlands guy

https://github.com/kayagoban/shadowlands-core/blob/master/shadowlands/credstick/ledger_ethdriver.py

@benjiqq
Copy link

benjiqq commented Aug 4, 2021

@benjiqq
Copy link

benjiqq commented Aug 7, 2021

made some progress on python with ledger using #34 branch

https://gist.github.com/benjyz/c4d96eb79a46c7d3d34d64f4870e2f8d

managed to get the version number and address from the device. have to read up on derivation paths. for some reason ledger live uses different paths

the code uses:
ETH_DERIVATION_PATH_PREFIX = "m/44'/60'/0'/"
ledger live uses
ETH_DERIVATION_PATH_PREFIX = "44'/60'/1'/0/0"

see
https://ethereum.stackexchange.com/questions/19055/what-is-the-difference-between-m-44-60-0-0-and-m-44-60-0

@benjiqq
Copy link

benjiqq commented Aug 7, 2021

should be this

ETH_DERIVATION_PATH = "m/44'/60'/0'/0/0"

@benjiqq
Copy link

benjiqq commented Aug 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants