HDAccount #33
Merged
HDAccount #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
August 25, 2018 18:53
…ed code to required entropy byte count be an element of [16,20,24,28,32], as described in BIP32
…path to setup.py, debugged mnemonic.py to work with python3, adapted function commenting style for the most functions
…path argument support for init. Added and implemented decodePath(...) function to represent the derivation path as a string in format (m/)idx_0/.../idx_n . Added path property to return the string formatted derivation path. Added __repr__ and __str__, adjusted __eq__ and __hash__. Included (very basic) unit test for deriveChild(...) . Adapted function describing commenting style for every function.
…..), signTransaction(...) . Added value check to deterministic.py
…ort tells me the contrary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #31 , putting this code "on-hold" until we can do proper cleanup and review.