Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local ECDSA utils in favor of using py_ecc API #47

Open
pipermerriam opened this issue Oct 25, 2018 · 3 comments
Open

Remove local ECDSA utils in favor of using py_ecc API #47

pipermerriam opened this issue Oct 25, 2018 · 3 comments

Comments

@pipermerriam
Copy link
Member

What was wrong?

The py_ecc library is now the canonical location for the native python ecc code. This library still contains copies of that code and uses them

How can it be fixed?

Update to use the py_ecc versions and remove the local implementations from this library.

@pipermerriam
Copy link
Member Author

Noting here that py-ecc is dropping some older python 3 version support: ethereum/py_ecc#22

@aashutoshrathi
Copy link

Hey, @pipermerriam
Is this issue similar to what I did here?
I would like to take this up.

@pipermerriam
Copy link
Member Author

Not exactly.

It'd be focused on removing these dependencies:

from .ecdsa import (
ecdsa_raw_recover,
ecdsa_raw_sign,
private_key_to_public_key,
)

In favor of using them directly from py_ecc, but.... currently, py_ecc doesn't expose these as public APIs so we would need to elevate them to be public APIs in the py_ecc library, and document them (probably in the README.md in the py_ecc repo. Then this library can import and use those primitives and remove the ecdsa.py and jacobian.py modules.

Also, it may be that the ecdsa.py and jacobian.py modules that are local here in this repo are favorable in terms of code style and organization so migrating that into the py_ecc repo might be good, but use your best judgement.

pacrob pushed a commit to pacrob/eth-keys that referenced this issue Dec 20, 2023
Better error if bump missing in make notes/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants