Drop python 3.4 and 3.5 support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carver @pipermerriam please review! 👍 |
carver
approved these changes
Oct 28, 2018
There was a problem hiding this comment.
Looks good to me! I'll go ahead and merge. If @pipermerriam thinks of a reason we can't drop py3.5 support, then we can always add it back in before release.
|
Thank you for merging! :) 💯 |
|
I think we need to keep 3.5 till py-evm drops it... https://github.com/ethereum/py-evm/blob/9870841a126fb53a6cbab2ef7bf3d46262fa23a8/setup.py#L16 but we can just do this as a major version bump so lets just do that. |
Merged
pacrob
pushed a commit
to pacrob/py_ecc
that referenced
this pull request
Oct 29, 2023
Remove attribution to specific person, update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11 fixes, raised after #18 (comment)
Tested against code, works well!
