ABI types improvements #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 15, 2024
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 15, 2024
reedsa
force-pushed
the
abi-utils-type-fixes
branch
from
2e20014
to
3019824
Compare
kclowes
reviewed
Apr 16, 2024
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 17, 2024
reedsa
force-pushed
the
abi-utils-type-fixes
branch
from
3019824
to
2a5214e
Compare
|
@kclowes these changes have been validated and work in each library which uses types. These types are not in use just yet so the changes here will not break anything. Should be good on this now, I'm ready to use these in ethereum/eth-utils#271. |
* Fix issue in release notes * Fix ABI types docs * Use specific types in ABIElement rather than base type
reedsa
force-pushed
the
abi-utils-type-fixes
branch
from
2a5214e
to
fc6bbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Encountered a few errors obscured in CI of the eth-utils updates.
ABIElementnow uses each Function type rather than the base type.ABIEventComponentadded as part of the event data model.How was it fixed?
This change fixes those errors seen in the eth-utils build.
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture