Change ABIFunctionInfo to ABIElementInfo
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Jun 25, 2024
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Jun 25, 2024
fselmo
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Some minor comments. I like the idea of deprecating but I could also do without it since it existed for a very brief period of time in this code base and it's 99.9% likely that we were the only ones that ever made use of it.
That said I also think creating a new branch to issue that deprecation wouldn't take too much dev time so I could do things "the right way" too I suppose 😄. No strong opinion there.
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Jun 25, 2024
|
Here's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
After using
ABIFunctionInfoI realized it should actually encompass allABIelement types. This should be namedABIElementInfoto match the newget_element_infoutility inweb3.More context:
Using this in ethereum/web3.py#3408
Here's the implementation of
get_element_infohttps://github.com/ethereum/web3.py/blob/23378b4c470230684cf8298fd6133238867153bc/web3/utils/abi.py#L187
Related to Issue #
Closes #
How was it fixed?
Replace
ABIFunctionInfowithABIElementInfoand allow allABIElementtypes as values of theabiattribute.Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture