Add is_hexstr function

[adamjsawicki]

What was wrong?

Fixes #137, it was decided that a second function is_hexstr should be added that returns False on any
non-string input call to the function.

How was it fixed?

The specified function was implemented.

To-Do

• [ X] Clean up commit history

• [ X] Add entry to the release notes

Cute Animal Picture

[njgheorghita]

🔥 Thanks for taking this on @swixx ! Just a couple thoughts and then we're good to merge!

• It can be helpful in the pr descriptions to put fixes #183 instead of per #183 since with fixes it will automatically close the issue once this is merged.
• If you could update the docs/utilities.rst file to match what's been done in this pr, that'd be great! (eg. note that is_hex is deprecated, and update the is_hex docs to is_hexstr)

[njgheorghita]

Nitpick: for consistency with the beginning of the warning msg consider updating to is_hexstr(value: Any)

[carver]

• eg. note that is_hex is deprecated

Let's separate that part out into another issue. I think we might want to keep both versions, where is_hex is the stricter option and presumes str. If @swixx opens another issue for that, then the discussion about keeping it doesn't need to block this PR.

[adamjsawicki]

@njgheorghita Made the requested changes. Per @carver's, I did not add anything to docs/utilities.rst.

[carver]

Looks like this line got duplicated

[njgheorghita]

Let's separate that part out into another issue. I think we might want to keep both versions, where is_hex is the stricter option and presumes str.

There's maybe some confusion around this from @carver's comment, at least there is on my end. I understood "that part" to reference the deprecation of is_hex() in the code - and not the task of updating the docs. eg. We want users to still be able to use is_hex() without seeing a deprecation warning.

If correct, there's a couple last changes - thanks again @swixx , sorry about the endless nitpicks.

• remove the deprecation warnings from is_hex() and its corresponding tests
• update docs/utilities.rst to document is_hexstr() and note why it's different from is_hex() - regardless of whether or not we deprecate is_hex() here, is_hexstr() should be documented

Finally, if you're up for it @swixx ...

If @swixx opens another issue for that, then the discussion about keeping it doesn't need to block this PR.

Where you should deprecate is_hex() and its corresponding tests/docs

[carver]

Yup, thanks for clarifying @njgheorghita -- that's exactly what I meant.

[adamjsawicki]

@carver will submit tonight. Just so we don't have to do another back and forth, how's the following?

.. note:: 

    This function differs from ``is_hex(value: Any)`` in that it will return
    False on all non-text type arguments, while ``is_hex`` will raise a ``TypeError``
    for all non-text type arguments.

[carver]

@carver will submit tonight. Just so we don't have to do another back and forth, how's the following?

.. note:: 

    This function differs from ``is_hex(value: Any)`` in that it will return
    False on all non-text type arguments, while ``is_hex`` will raise a ``TypeError``
    for all non-text type arguments.

Yup, looks good!

[carver]

@njgheorghita after you do your last lookover, no need to wait for me to merge 👍

[njgheorghita]

Excellent, thanks @swixx !!