Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_hexstr function #183

Merged
merged 13 commits into from Jan 14, 2020
Merged

Add is_hexstr function #183

merged 13 commits into from Jan 14, 2020

Commits on Dec 27, 2019

  1. Add deprecation warning.

    Adam Sawicki committed Dec 27, 2019
    Copy the full SHA
    ce89dc4 View commit details
    Browse the repository at this point in the history

  2. Modify tests to reflect deprecation warning

    Adam Sawicki committed Dec 27, 2019
    Copy the full SHA
    0466778 View commit details
    Browse the repository at this point in the history

  3. Add is_hexstr(value: Any) -> bool 

    As per ethereum#137,
it was decided that a new function should be added with
the signature above that returns 'False' on any non-string
input.

The function has been added with appropiate test cases.
    Adam Sawicki committed Dec 27, 2019
    Copy the full SHA
    fc2687e View commit details
    Browse the repository at this point in the history

  4. Remove calls to is_text that are redundant 

    Due to the implementation of `is_hexstr()`, calls
to `is_text` are unneeded that occur before any call
to `is_hexstr()`.
    Adam Sawicki committed Dec 27, 2019
    Copy the full SHA
    63a132b View commit details
    Browse the repository at this point in the history

  5. Add newsfragment

    Adam Sawicki committed Dec 27, 2019
    Copy the full SHA
    c6c29a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Fix typo

    Adam Sawicki committed Jan 8, 2020
    Copy the full SHA
    f0b423e View commit details
    Browse the repository at this point in the history

  2. Typo fix and added test with '0X' prefix

    Adam Sawicki committed Jan 8, 2020
    Copy the full SHA
    e06bddb View commit details
    Browse the repository at this point in the history

  3. Modify warning funcion signature for consistency

    Adam Sawicki committed Jan 8, 2020
    Copy the full SHA
    7a46bff View commit details
    Browse the repository at this point in the history

  4. Use 'is_text(value)' for consistency

    Adam Sawicki committed Jan 8, 2020
    Copy the full SHA
    312dbc9 View commit details
    Browse the repository at this point in the history

  5. Remove duplicate test case

    Adam Sawicki committed Jan 8, 2020
    Copy the full SHA
    01688ad View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Remove deprecation warning on is_hex()

    Adam Sawicki committed Jan 12, 2020
    Copy the full SHA
    fd0da76 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Add documentation for is_hexstr()

    Adam Sawicki committed Jan 13, 2020
    Copy the full SHA
    b7dcb33 View commit details
    Browse the repository at this point in the history

  2. Update docs/utilities.rst 

    Co-Authored-By: Jason Carver <ut96caarrs@snkmail.com>
    @adamjsawicki @carver
    adamjsawicki and carver committed Jan 13, 2020
    Copy the full SHA
    ac8a4e5 View commit details
    Browse the repository at this point in the history