Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update_networks.py to get rid of warnings for Astar zkEVM and Yooldo Verse #276

Merged
merged 3 commits into from
May 6, 2024

Conversation

florian-cl
Copy link
Contributor

What was wrong?

When using eth-utils 4.1.0, we currently see the following errors:

/Users/<repopath>/.venv/lib/python3.12/site-packages/eth_utils/network.py:61: UserWarning: Network 345 with name 'Yooldo Verse Mainnet' does not have a valid ChainId. eth-typing should be updated with the latest networks.
  networks = initialize_network_objects()
/Users/<repopath>/.venv/lib/python3.12/site-packages/eth_utils/network.py:61: UserWarning: Network 12611 with name 'Astar zkEVM' does not have a valid ChainId. eth-typing should be updated with the latest networks.
  networks = initialize_network_objects()

Related to Issue #
Closes #

How was it fixed?

Ran the python update_networks.py command

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kootsZhin
Copy link

Also seeing these when using web3.py, is there a way to get rid of it when using as dependency?

@reedsa reedsa requested review from fselmo, pacrob and kclowes May 6, 2024 15:26
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@reedsa reedsa merged commit fa398e3 into ethereum:main May 6, 2024
20 checks passed
@florian-cl florian-cl deleted the update_networks branch May 6, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants