Convert precision to localcontext #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth_utils/currency.py
Outdated
| @@ -46,7 +43,7 @@ | |||
| MAX_WEI = 2 ** 256 - 1 | |||
|
|
|||
|
|
|||
| def from_wei(number, unit): | |||
| def from_wei(number, unit, precision=999): | |||
There was a problem hiding this comment.
I don't think this should be configurable. It should just be a constant, otherwise, bad user decisions lead to imprecise monetary calculations.
| if d_number < 1 and '.' in s_number: | ||
| with localcontext() as ctx: | ||
| multiplier = len(s_number) - s_number.index('.') - 1 | ||
| ctx.prec = multiplier | ||
| d_number = decimal.Decimal(value=number, context=ctx) * 10**multiplier | ||
| unit_value /= 10**multiplier | ||
|
|
||
| result_value = d_number * unit_value | ||
| with localcontext() as ctx: |
There was a problem hiding this comment.
I'm curious if this one is needed. Do tests pass if it's removed? The d_number already has the appropriate precision from the context above.
There was a problem hiding this comment.
The two conversion_round_trip_* tests fail without this. Specifically when the number is '10000000000.000000000000000001' it drops the trailing 1.
njgheorghita
force-pushed
the
make-decimal-prec-local
branch
from
fced9ca
to
923cdc2
Compare
|
Note: I'll need to make a new |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
DefaultContext was being used to set precision.
How was it fixed?
Added precision as optional kwarg to allow users to set their own precision (@pipermerriam was this the right move?) and set precision using localcontext.
Cute Animal Picture
closes #44