Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hash_tree_root everywhere #739

Merged
merged 6 commits into from
Mar 8, 2019
Merged

Use hash_tree_root everywhere #739

merged 6 commits into from
Mar 8, 2019

Conversation

JustinDrake
Copy link
Collaborator

And get rid of merkle_root. This is possible because of SSZ tuples.

@JustinDrake
Use hash_tree_root everywhere
1269542 
And get rid of merkle_root. This is possible because of SSZ tuples.
@vbuterin
Copy link
Contributor

vbuterin commented Mar 8, 2019

I don't see how this can be valid python. hash_tree_root for non-SSZ-containers doesn't distinguish between fixed size and variable size lists, but the spec does. Maybe add an optional typ argument to hash_tree_root ?

@JustinDrake
Copy link
Collaborator Author

I defined a new SSZ object :)

@djrtwo
Copy link
Contributor

djrtwo commented Mar 8, 2019

I'll make sure this runs in the executable spec before merging

@djrtwo
Copy link
Contributor

djrtwo commented Mar 8, 2019

lol found a couple of other bugs when running the state transition through many empty epochs! patching a fix in another PR

djrtwo
djrtwo approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass!

@djrtwo djrtwo merged commit aa29cd7 into dev Mar 8, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-7 branch March 8, 2019 21:58
@terencechain terencechain mentioned this pull request Mar 15, 2019
Closed
@schroedingerscode schroedingerscode mentioned this pull request Mar 15, 2019
Closed
@hwwhww hwwhww mentioned this pull request Mar 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinDrake @vbuterin @djrtwo @hwwhww