Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth2 Banner bug #1768

Closed
ryancreatescopy opened this issue Nov 10, 2020 · 3 comments
Closed

Eth2 Banner bug #1768

ryancreatescopy opened this issue Nov 10, 2020 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@ryancreatescopy
Copy link
Contributor

ryancreatescopy commented Nov 10, 2020 •
edited

Describe the bug

Occasionally the eth2 banner doesn't render correctly. I've had this error on both mobile and desktop, pre and pose v2.10.0 deploy.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an /eth2 page
  2. Look at banner

Expected behavior

Banner should have a primary colour background and text should be centered.

Screenshots

image
@ryancreatescopy ryancreatescopy mentioned this issue Nov 10, 2020
Merged
7 tasks
@tvanepps
Copy link
Contributor

image

yup, seeing the same issue on desktop

@wackerow wackerow mentioned this issue Nov 11, 2020
Merged
@wackerow
Copy link
Member

Fixed =)

@ryancreatescopy ryancreatescopy added the bug 🐛 Something isn't working label Nov 11, 2020
@samajammin samajammin mentioned this issue Nov 11, 2020
Merged
samajammin added a commit that referenced this issue Nov 11, 2020
@samajammin
Merge pull request #1770 from wackerow/w/callout#1768
fc0725a 
Adds component import/exports to templates [Fixes #1768]
@samajammin samajammin reopened this Nov 11, 2020
ryancreatescopy added a commit that referenced this issue Nov 11, 2020
@ryancreatescopy
Merge pull request #1791 from ethereum/fix-eth2-banner
e6d7e79 
Fix Eth2 banner display [Fixes #1768]
@samajammin samajammin mentioned this issue Nov 12, 2020
Merged
@samajammin
Copy link
Contributor

This appears to still be an issue:
Image 2020-11-13 at 3 11 40 PM

@samajammin samajammin reopened this Nov 13, 2020
@samajammin samajammin mentioned this issue Nov 13, 2020
Merged
ryancreatescopy added a commit that referenced this issue Nov 15, 2020
@ryancreatescopy
Merge pull request #1830 from ethereum/fix-banner-notification
e90f0b8 
Refactor BannerNotification [Fixes #1768]
@samajammin samajammin mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samajammin @tvanepps @ryancreatescopy @wackerow