Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BannerNotification [Fixes #1768] #1830

Merged
merged 6 commits into from
Nov 15, 2020
Merged

Refactor BannerNotification [Fixes #1768] #1830

merged 6 commits into from
Nov 15, 2020

Conversation

samajammin
Copy link
Contributor

@samajammin samajammin commented Nov 13, 2020 •
edited

Description

This should actually fix it this time 馃

  • Update position to relative (vs absolute) to avoid complex Layout margin logic
  • Add container divs (flex-direction: column) to wrap BannerNotification in Layout & Docs template

Related Issue

#1768

@samajammin samajammin marked this pull request as draft November 13, 2020 23:40
@samajammin samajammin marked this pull request as ready for review November 14, 2020 23:26
@samajammin samajammin changed the title Add shouldShow prop to BannerNotification [Fixes #1768] Refactor BannerNotification [Fixes #1768] Nov 14, 2020
@ryancreatescopy ryancreatescopy merged commit e90f0b8 into dev Nov 15, 2020
@ryancreatescopy ryancreatescopy deleted the fix-banner-notification branch November 15, 2020 08:56
@samajammin samajammin mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancreatescopy ryancreatescopy ryancreatescopy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samajammin @ryancreatescopy