Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Eth2 service announcement dismissible #1837

Closed
samajammin opened this issue Nov 15, 2020 · 0 comments
Closed

Make Eth2 service announcement dismissible #1837

samajammin opened this issue Nov 15, 2020 · 0 comments
Assignees
@samajammin
Labels
feature ✨ This is enhancing something existing or creating something new

Comments

@samajammin
Copy link
Contributor

samajammin commented Nov 15, 2020 •
edited

Is your feature request related to a problem? Please describe.

We show this prominently on every upgrade page (eth2.js template), particularly on mobile where it's the first piece of content.

This should be dismissible so it's not popping up on every single upgrade page.

Describe the solution you'd like

Make the card dismissible

  • Use local storage to lookup/create item when dismissed

Describe alternatives you've considered
Keep as is

Additional context
None
@samajammin samajammin added the feature ✨ This is enhancing something existing or creating something new label Nov 15, 2020
@samajammin samajammin self-assigned this Nov 15, 2020
samajammin added a commit that referenced this issue Nov 15, 2020
@samajammin
Add DismissibleCard [Fixes #1837]
acb3d24
@samajammin samajammin mentioned this issue Nov 15, 2020
Merged
@samajammin samajammin changed the title Make Eth2 service announcement dismiss-able Make Eth2 service announcement dismissible Nov 15, 2020
samajammin added a commit that referenced this issue Nov 16, 2020
@samajammin
Merge pull request #1839 from ethereum/dismissable-psa
cc10682 
Add DismissibleCard [Fixes #1837]
@samajammin samajammin mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samajammin samajammin

Labels
feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samajammin