Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DismissibleCard [Fixes #1837] #1839

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Add DismissibleCard [Fixes #1837] #1839

merged 2 commits into from
Nov 16, 2020

Conversation

samajammin
Copy link
Contributor

Description

  • Refactor AnnouncementCard to DismissibleCard
  • Stores key in local storage to track dismiss history

Related Issue

#1837

@samajammin
Copy link
Contributor Author

@ryancreatescopy note - this will look wonky on mobile until #1836 is merged.

ryancreatescopy
ryancreatescopy reviewed Nov 15, 2020
View reviewed changes
Copy link
Contributor

@ryancreatescopy ryancreatescopy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Will that other issue fix the fact that the page top-padding doesn't change? In this PR, I close the banner and there remains a lot of padding at the top of the page rather than the page's content shifting up to fill the space.

@samajammin
Copy link
Contributor Author

@ryancreatescopy it should. I'll rebase off dev & we can test to confirm.

@samajammin
Copy link
Contributor Author

@ryancreatescopy works for me! Tested on my iPhone.

ryancreatescopy
ryancreatescopy approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@ryancreatescopy ryancreatescopy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samajammin samajammin merged commit cc10682 into dev Nov 16, 2020
@samajammin samajammin deleted the dismissable-psa branch November 16, 2020 15:54
@samajammin samajammin mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancreatescopy ryancreatescopy ryancreatescopy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samajammin @ryancreatescopy