Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out the vuepress theme #34

Closed
man15h opened this issue May 1, 2019 · 2 comments
Closed

Separate out the vuepress theme #34

man15h opened this issue May 1, 2019 · 2 comments
Labels
question ❓ Further information is requested

Comments

@man15h
Copy link

man15h commented May 1, 2019

It would be great if the Vuepress theme is separate out from the project. It'll be easy to maintain code and content another advantage is that the theme can be used or maintained by any other Vuepress developer. Let me know if you agree I'm happy to submit a PR.

@samajammin
Copy link
Member

Hey @man15h - thanks for taking the time to add this idea & offer to help out!

I'm open to this but I'm curious to hear more - why do you think it'd advantageous to move the theme into a separate repo?

It'll be easy to maintain code and content

My hunch is that your proposal would actually make it harder to maintain code and content because it would create the additional overhead of managing 2 repositories instead of 1. Any update to the styles & copy of the site would then require 2 PRs, which may deter people from contributing.

I appreciate that other Vuepress developers may eventually find value in using the theme but as it stands now, it's nearly identical to the default Vuepress theme & I question if it's worth the effort at this point in time.

@samajammin samajammin added the question ❓ Further information is requested label Sep 13, 2019
@samajammin
Copy link
Member

@man15h I'm going to close this issue for maintenance purposes. Feel free to re-open if you have a response to my question. Thanks!

TylerAPfledderer pushed a commit to TylerAPfledderer/ethereum-org-website that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question ❓ Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants