-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Todo at src/components/BugBountyCards.js:111
on dev
Branch
#4303
Comments
I'd like to be assigned to this issue (if possible) ( ^___^ ) |
Hey @Hakeemmidan. Thanks for offering to help on this. I agree we should refactor this (as per the todo). However because of how the translations work on ethereum.org it would be a lot of overhead to rename the labels. I think moving data into an array of objects and mapping through them is what we were looking for here. |
This issue is stale because it has been open 45 days with no activity. |
Hey @Hakeemmidan , still working on this ? If not, can I pick this one up ? |
Hi @ShubhankarKG, thank you for reaching out! = ) |
Resolve 'BugBountyCards.js' todo. Fixes #4303
Is your feature request related to a problem? Please describe.
Not really a problem. Just some syntax clean-up.
I'd like to resolve the todo at
src/components/BugBountyCards.js:111
on thedev
branch:Describe the solution you'd like
Associate an index number (starting from 0) with each card and do string interpolation to change the id during the iteration. E.g.
Nevertheless, that wouldn't work with some IDs that use words instead of numbers, such as
"page-eth2-bug-bountycard-low"
, and each card's link. So I'd need to change those IDs to just use numbers instead of words, and have a simple array of links that has an index that's the same as its parent-card index number.Describe alternatives you've considered
Move all existing data into an array of objects, and iterate through them.
It'd be something like this:
Which seems a little more verbose.
Additional context
(page screenshot)
The text was updated successfully, but these errors were encountered: