Resolve 'BugBountyCards.js' todo. Fixes #4303 #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakeemmidan
requested review from
corwintines,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
Hakeemmidan
force-pushed
the
resolve-todo_fixes-4303
branch
from
19a20d1
to
f4de45a
Compare
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
minimalsm
requested changes
Jan 3, 2022
There was a problem hiding this comment.
Hey @Hakeemmidan thanks for the PR on this and happy new year to you 😀✌️
Looks good overall, left a few comments but nothing major so feel free to disagree.
|
Hi @minimalsm, Thank you for the response, and happy new year to you as well! 🎇🎈✨ I adjusted the code based on the feedback. Please let me know if you have any questions or requests |
corwintines
approved these changes
Jan 3, 2022
|
@corwintines Thank you! 🙏 Glad to help |
|
Thanks again @Hakeemmidan 🚀 |
|
@minimalsm Thank you! 🙏 Glad to help |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves the todo at
src/components/BugBountyCards.js:111on thedevbranchIt should be the same. I couldn't spot a difference. Comment below if you do.
Related Issue
Fixes #4303