Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read address aloud functionality on the staking deposit address reads address incorrectly #7690

Closed
minimalsm opened this issue Sep 5, 2022 · 5 comments
Closed

Read address aloud functionality on the staking deposit address reads address incorrectly #7690

minimalsm opened this issue Sep 5, 2022 · 5 comments
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@minimalsm
Copy link
Contributor

Describe the bug

The 'read aloud' functinonality on the staking deposit contract page does not work correctly. When following a number the letter 'C' is read as 'degrees Celsius' and the letter 'F' as 'degrees Fahrenheit'.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://ethereum.org/en/staking/deposit-contract/'
  2. Click on 'Read address aloud'
  3. See error

Expected behavior

It should read the characters exactly as they appear (characters should not be relational to one another)

Smartphone (please complete the following information):

  • Device: iMac
  • OS: MacOS 12.5.1
  • Browser: Brave
  • Version: v1.43.89

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.
@minimalsm minimalsm added bug 🐛 Something isn't working help wanted Extra attention is needed or someone is needed to help good first issue Good item to try if you're new to contributing labels Sep 5, 2022
@hursittarcan
Copy link
Contributor

I could not reproduce this issue. It works ok on my device. (Win 10, Google Chrome v.104.0)

@sadiejay
Copy link

sadiejay commented Sep 5, 2022 •
edited

I can recreate the issue on my device:

OS: MacOS 12.5.1
Browser: Firefox
Version: v104.0.1

This snippet: 356 cBB 839 Cbe ... 5Fa :

Is read as three five six cee bee bee eight three nine degrees Celsius ... five degrees Fahrenheit ay

It seems to be an inconsistent behavior.

@sadiejay
Copy link

sadiejay commented Sep 5, 2022

May I be assigned this issue? I'm not sure how to tackle this but would like to try!

nagabhiru added a commit to nagabhiru/ethereum-org-website that referenced this issue Sep 7, 2022
@nagabhiru
Fix read address aloud functionality [ethereum#7690]
72a7f4e
@nagabhiru nagabhiru mentioned this issue Sep 7, 2022
Merged
nagabhiru added a commit to nagabhiru/ethereum-org-website that referenced this issue Sep 8, 2022
@nagabhiru
Fix read address aloud functionality [ethereum#7690]
5eeb2b6
nagabhiru added a commit to nagabhiru/ethereum-org-website that referenced this issue Sep 8, 2022
@nagabhiru
Fix read address aloud functionality [ethereum#7690]
fa374b8
minimalsm added a commit that referenced this issue Sep 8, 2022
@minimalsm
Merge pull request #7736 from nagabhiru/Fix-7690
cdd812e 
Fix read address aloud functionality [#7690]
@minimalsm
Copy link
Contributor Author

Closed by #7736

@sadiejay
Copy link

sadiejay commented Sep 8, 2022

Oops did I miss something? I thought a comment was necessary before submitting a PR. Has that changed @minimalsm ?

@corwintines corwintines mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sadiejay @minimalsm @hursittarcan