Fix read address aloud functionality [#7690] #7736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagabhiru
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
reviewed
Sep 8, 2022
| @@ -229,7 +229,7 @@ const DepositContractPage = ({ | |||
| // Create textToSpeechRequest | |||
| let speech = new SpeechSynthesisUtterance() | |||
| speech.lang = "en-US" | |||
| speech.text = DEPOSIT_CONTRACT_ADDRESS.split("").join(" ") | |||
| speech.text = DEPOSIT_CONTRACT_ADDRESS.split("").join(",") | |||
There was a problem hiding this comment.
Nice. One note: this rapidly decreases the speed at which this is read, maybe we increase speech.rate to compensate?
minimalsm
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Thanks for the PR @nagabhiru, this solves the problem 🥳 Left one small comment about the reading speed that we could probably iron out.
minimalsm
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Thanks @nagabhiru, and thanks for explaining the solution. TIL :-)!
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the read address aloud issue in #7690
Description
We were using the Web Speech API and setting the SpeechSynthesisUtterance.text to DEPOSIT_CONTRACT_ADDRESS.split("").join(" ")
When following a number the letter 'C' is read as 'degrees Celsius' and the letter 'F' as 'degrees Fahrenheit'.
I have added commas between the characters so that each character is read separately
Related Issue