Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2024 community events and refactor to typescript #12000

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Add 2024 community events and refactor to typescript #12000

merged 8 commits into from
Jan 25, 2024

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Jan 23, 2024 •
edited

Description

  • Refactor community-events.json to be typescript
  • Clean old 2023 events
  • Add 2024 events
  • Fix load more bug where it would show when there were no more events to load

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit bcd8c14
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65b1b7d1d9659f0008c18b83
😎 Deploy Preview https://deploy-preview-12000--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added event 📅 This issue or pull request is related to an event listing review needed 👀 labels Jan 23, 2024
@corwintines corwintines mentioned this pull request Jan 24, 2024
Merged
wackerow
wackerow requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Overall looks good, just left a few suggestions (while we're in this file cleaning up TypeScript) to tidy up a couple more things per our code conventions

src/data/community-events.ts Outdated Show resolved Hide resolved
src/components/UpcomingEventsList.tsx Outdated Show resolved Hide resolved
src/components/UpcomingEventsList.tsx Outdated Show resolved Hide resolved
src/components/UpcomingEventsList.tsx Show resolved Hide resolved
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jan 24, 2024
wackerow
wackerow requested changes Jan 25, 2024
View reviewed changes
src/data/community-events.ts Outdated Show resolved Hide resolved
src/components/UpcomingEventsList.tsx Outdated Show resolved Hide resolved
src/components/UpcomingEventsList.tsx Outdated Show resolved Hide resolved
wackerow
wackerow approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@corwintines corwintines merged commit d4290f9 into dev Jan 25, 2024
9 of 10 checks passed
@corwintines corwintines deleted the add2024Events branch January 25, 2024 03:13
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz nhsz is a code owner

Assignees
No one assigned
Labels
event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corwintines @wackerow