Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETH Belgrade 2024 to community events #11813

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

develo-pera
Copy link
Contributor

Add ETH Belgrade 2024 to the list

Description

Added ETH Belgrade 2024 website, description and dates

Add ETH Belgrade 2024 to the list
Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit ac64b40
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65b17c63b60ce10008160329

@github-actions github-actions bot added event 📅 This issue or pull request is related to an event listing review needed 👀 labels Dec 16, 2023
@develo-pera
Copy link
Contributor Author

@wackerow who can I ask to check this PR? Thank you

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just patched the whitespace. Holding off on merging for the time being while the Next.js migration is in flight, but will get it merged soon.

{
"title": "ETH Belgrade",
"to": "https://ethbelgrade.rs/",
"sponsor": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minimalsm @corwintines We haven't been enforcing this, so not going to block this PR, but separately we should decide if we want to keep the "sponsor" field going forward or to just remove, since it clearly hasn't been enforced in the current list of events.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR here removing it and typing this data: #12000

Going to bring this in here, and will fix anything that needs to be done in the above PR.

src/data/community-events.json Outdated Show resolved Hide resolved
@wackerow wackerow changed the title Update community-events.json Add ETH Belgrade 2024 to community events Jan 8, 2024
@corwintines corwintines self-assigned this Jan 24, 2024
@corwintines corwintines merged commit 7742383 into ethereum:dev Jan 24, 2024
2 of 6 checks passed
Copy link

gitpoap-bot bot commented Jan 24, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event 📅 This issue or pull request is related to an event listing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants