Fix code splitting issue #7943
Merged
Fix code splitting issue #7943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a custom webpack config
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
the
dependencies 📦
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
commented
Sep 21, 2022
github-actions
bot
added
the
needs review 👀
pettinarip
commented
Sep 23, 2022
| Button, | ||
| Link, | ||
| Tag, | ||
| } |
There was a problem hiding this comment.
This took me a very long time to detect 😆 hate these kind of issues.
Once I removed the .babelrc for some reason these exports stop working as I was expecting. I had to export these in a more manual way, with the expected structure.
wackerow
approved these changes
Oct 5, 2022
corwintines
approved these changes
Oct 5, 2022
Merged
|
Is there any perf monitoring on the repo to determine how much this change improved the bundle size? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the inclusion of a custom
.babelrc(on v4) code splitting stopped working correctly. This is due to a Gatsby bug.Description
In order to fix it, we have deleted the custom
.babelrc(since there seems to be no way of ignoring it from Gatsby) and we have created a custom webpack config file to be used bynetlify-lambda.