-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code splitting issue #7943
Merged
Merged
Fix code splitting issue #7943
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fbe19dc
fix code splitting by removing the .babelrc file and replace it with …
pettinarip 8266971
Merge branch 'dev' into fix-code-splitting
pettinarip 27a538a
fix export of chakra theme components
pettinarip bb2556c
Merge branch 'dev' into fix-code-splitting
pettinarip File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,11 @@ | ||
| export * from "./Link" | ||
| export * from "./Button" | ||
| export * from "./Tag" | ||
| export * from "./Modal" | ||
| import { Button } from "./Button" | ||
| import { Link } from "./Link" | ||
| import { Tag } from "./Tag" | ||
| import { Modal } from "./Modal" | ||
|
|
||
| export default { | ||
| Button, | ||
| Link, | ||
| Tag, | ||
| Modal, | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Expose a custom webpack config in order to let netlify-lambda read it and | ||
| // build the TS lambda functions. This way, netlify-lambda use the same | ||
| // babel config that Gatsby does. | ||
| module.exports = { | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.(m?js|ts)?$/, | ||
| exclude: /(node_modules|bower_components)/, | ||
| use: { | ||
| loader: "babel-loader", | ||
| options: { | ||
| presets: [ | ||
| "@babel/preset-typescript", | ||
| [ | ||
| "babel-preset-gatsby", | ||
| { | ||
| targets: { | ||
| browsers: [">0.25%", "not dead"], | ||
| }, | ||
| }, | ||
| ], | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took me a very long time to detect 😆 hate these kind of issues.
Once I removed the
.babelrcfor some reason these exports stop working as I was expecting. I had to export these in a more manual way, with the expected structure.