Issue-1184: no distinction between uint and int #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2018 20:28
- added abstract numeric type for shared method between int and uint - distinction between uint and int in getType - added two new subclasses for SoldityType - added two testcases for int and uint SoldityType
- fixed StandaloneBlockchainTest#encodeTest1 as the expectation was wrong
zilm13
requested changes
Sep 26, 2018
ethereumj-core/src/test/java/org/ethereum/solidity/SolidityTypeTest.java
Show resolved
Hide resolved
ethereumj-core/src/test/java/org/ethereum/util/StandaloneBlockchainTest.java
Outdated
Show resolved
Hide resolved
ethereumj-core/src/test/java/org/ethereum/solidity/SolidityTypeTest.java
Outdated
Show resolved
Hide resolved
ethereumj-core/src/main/java/org/ethereum/solidity/SolidityType.java
Outdated
Show resolved
Hide resolved
- formatting - throw exception if a biginteger below zero is encoded to uint - made old regression test encode1 visible again - reuse of Hex-encoding in test
zilm13
requested changes
Sep 27, 2018
ethereumj-core/src/test/java/org/ethereum/solidity/SolidityTypeTest.java
Show resolved
Hide resolved
ethereumj-core/src/main/java/org/ethereum/solidity/SolidityType.java
Outdated
Show resolved
Hide resolved
ethereumj-core/src/main/java/org/ethereum/solidity/SolidityType.java
Outdated
Show resolved
Hide resolved
- formatting - license intro added to test
zilm13
approved these changes
Sep 27, 2018
|
@jondoe1337 cool, thank you! |
mkalinin
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During regression testing the
org.ethereum.util.StandaloneBlockchainTest.encodeTest1()failed because the assumption on the expected value was wrong, imho:The written SolidityContract has a setter-alike function and the value that is set is tested. However the value is an unsigned-int, so i doubt that the expected value
-1was correct due to the wrong uint implementation, but feel free to clear my mind.