New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Ethereum.close() from trying to shut down twice #722

Merged

Nashatyrev merged 1 commit into ethereum:develop from gemini:shutdown-loop

Feb 3, 2017

Contributor

ewiner commented Feb 2, 2017

As reported at https://gitter.im/ethereum/ethereumj?at=5890fb0edcb66e4f76d5367d, currently EthereumImpl.close() calls ApplicationContext.close(), which calls EthereumImpl.stop(), which calls EthereumImpl.close() again.

This breaks the loop so that EthereumJ only attempts to shut down once.


          keep Ethereum.close() from trying to shut down twice

4749be7

coveralls commented Feb 2, 2017

Coverage decreased (-0.02%) to 56.065% when pulling 4749be7 on gemini:shutdown-loop into 6871ca2 on ethereum:develop.

Nashatyrev merged commit 46c070f into ethereum:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet