-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename EVMC_LATEST_REVISION to EVMC_MAX_REVISION #184
Conversation
I think this is a breaking change, unless you plan to make a 7.x release next I'd suggest to postpone this. As a workaround we could have both enum values in 6.x and remove the old one in 7.x |
I marked the |
* | ||
* @deprecated Replaced with ::EVMC_MAX_REVISION. | ||
*/ | ||
EVMC_LATEST_REVISION EVMC_DEPRECATED = EVMC_MAX_REVISION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chfast doxygen cannot deal with this: https://ethereum.github.io/evmc/group__EVMC.html#ggae5759b1590071966ccf6a505b52a0ef7a0cfbd8a675a6db896ca8cc0fd2b8a30f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shit happens...
Closes #175