Rename EVMC_LATEST_REVISION to EVMC_MAX_REVISION #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a breaking change, unless you plan to make a 7.x release next I'd suggest to postpone this. As a workaround we could have both enum values in 6.x and remove the old one in 7.x |
|
I marked the |
axic
approved these changes
Jan 21, 2019
axic
reviewed
Jan 21, 2019
| * | ||
| * @deprecated Replaced with ::EVMC_MAX_REVISION. | ||
| */ | ||
| EVMC_LATEST_REVISION EVMC_DEPRECATED = EVMC_MAX_REVISION |
There was a problem hiding this comment.
@chfast doxygen cannot deal with this: https://ethereum.github.io/evmc/group__EVMC.html#ggae5759b1590071966ccf6a505b52a0ef7a0cfbd8a675a6db896ca8cc0fd2b8a30f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175