-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp: Rename result::raw() to result::release_raw() #293
Conversation
@@ -2,6 +2,8 @@ | |||
|
|||
## [6.2.2] - unreleased | |||
|
|||
- Changed: [[#293](https://github.com/ethereum/evmc/pull/293)] | |||
In C++ API `evmc::result::raw()` renamed to `evmc::result::release_raw()`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is, but the comment should at least be merged into 6.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's breaking, but 6.2 has broken C++ API anyway. Besides, this method is used internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, raw
was introduced in 6.2.1 via #257. I don't think renaming it is fixing a bug, the bug was fixed before the renaming, wasn't it?
e2c87b5
to
3ffadec
Compare
Based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leak_raw
sounds ok as well. release_raw
sounds to me like a destructor or something that releases the associated resources.
|
3ffadec
to
a70e297
Compare
Renamed to |
But "acquire" is the opposite of what happens. Maybe it could look fine if it were a free function like |
a70e297
to
3ffadec
Compare
No description provided.