Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Add helper for adding vmtester based VM test #303

Merged
merged 3 commits into from
Jul 23, 2019
Merged

cmake: Add helper for adding vmtester based VM test #303

merged 3 commits into from
Jul 23, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented May 29, 2019 •
edited

Closes #296.
Requires #336, change the CMake command accordingly.

Required testing:

@chfast chfast added this to In progress in v6.3 via automation May 29, 2019
@chfast chfast marked this pull request as ready for review July 17, 2019 12:44
@chfast chfast requested review from axic and gumb0 July 17, 2019 12:44
@axic
Copy link
Member

axic commented Jul 17, 2019

You want to add this to the documentation too?

@chfast
Copy link
Member Author

chfast commented Jul 17, 2019 •
edited

You want to add this to the documentation too?

No. There is no documentation for CMake.

gumb0
gumb0 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everything I can understand, but nothing looks wrong

v6.3 automation moved this from In progress to Reviewer approved Jul 17, 2019
@chfast chfast merged commit 1a45ce6 into master Jul 23, 2019
v6.3 automation moved this from Reviewer approved to Done Jul 23, 2019
@chfast chfast deleted the cmake_vmtester_helper branch July 23, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 gumb0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v6.3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CMake helper for running vmtester on given target
3 participants
@chfast @axic @gumb0