loader: Make error_code in evmc_load_and_create() optional #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
loader_error_code
branch
2 times, most recently
from
f206c5d
to
bf23350
Compare
axic
reviewed
Jun 3, 2019
gumb0
reviewed
Jun 3, 2019
gumb0
approved these changes
Jun 3, 2019
axic
reviewed
Jun 3, 2019
include/evmc/loader.h
Outdated
| * the ::EVMC_LOADER_INVALID_ARGUMENT is signaled. | ||
| * @param error_code The pointer to the error code. If not NULL the value is set to | ||
| * ::EVMC_LOADER_SUCCESS on success or any other error code as described above. | ||
| * @return The pointer to the created VM. |
There was a problem hiding this comment.
Or NULL in case of an error. An error_code is supplied in this case.
Changed: In `evmc_load_and_create()` the `error_code` is optional (can be `NULL`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.