C++: Add basic types based on C types #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
cpp_basic_types
branch
2 times, most recently
from
4f71fe0
to
ad2be01
Compare
|
Some of this is duplicated in |
The |
Why not move stuff in this PR properly? |
Will be done in this PR. |
chfast
force-pushed
the
cpp_basic_types
branch
7 times, most recently
from
8b4ea41
to
02cfbe2
Compare
chfast
force-pushed
the
cpp_basic_types
branch
2 times, most recently
from
5f104ec
to
e85c1c1
Compare
Merged
|
Ready. |
axic
reviewed
Jul 23, 2019
| { | ||
| using namespace evmc; | ||
| using namespace fnv; | ||
| return static_cast<size_t>(fnv1a_by64( |
There was a problem hiding this comment.
So this would truncate to the lower 32 bits on a 32-bit machine?
axic
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic types
addressandbytes32have received their C++ wrappers to assure they are always initialized. They also have convenient operator overloadings for comparison and usage as keys in standard containers.Closes #352