-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: Add basic types based on C types #357
Conversation
4f71fe0
to
ad2be01
Compare
Some of this is duplicated in |
The |
Why not move stuff in this PR properly? |
Will be done in this PR. |
8b4ea41
to
02cfbe2
Compare
5f104ec
to
e85c1c1
Compare
Ready. |
{ | ||
using namespace evmc; | ||
using namespace fnv; | ||
return static_cast<size_t>(fnv1a_by64( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this would truncate to the lower 32 bits on a 32-bit machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
The basic types
address
andbytes32
have received their C++ wrappers to assure they are always initialized. They also have convenient operator overloadings for comparison and usage as keys in standard containers.Closes #352