Implement standalone RLP encoding for uint64 to decouple from EVM state #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 97.79% 0.00% -97.80%
==========================================
Files 110 18 -92
Lines 10822 1361 -9461
==========================================
- Hits 10583 0 -10583
+ Misses 239 0 -239
Flags with carried forward coverage won't be shown. Click here to find out more. |
chfast
requested changes
Feb 12, 2024
There was a problem hiding this comment.
No, this does not look good at all. This code doesn't even build.
The job is to copy rlp:: utils here and trim it to what is needed for computing the create address. Which is: encode uint64_t number, encode the 20-byte address, and finally the RLP list of these two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potential fix #783