Update PayloadV3 with data gas used
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
May 31, 2023
lightclient
reviewed
May 31, 2023
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
hwwhww
approved these changes
Jun 1, 2023
yperbasis
approved these changes
Jun 2, 2023
tersec
added a commit
to status-im/nim-web3
that referenced
this pull request
Jun 3, 2023
tersec
added a commit
to status-im/nim-web3
that referenced
this pull request
Jun 3, 2023
tersec
added a commit
to status-im/nim-eth
that referenced
this pull request
Jun 3, 2023
tersec
added a commit
to status-im/nim-eth
that referenced
this pull request
Jun 3, 2023
yperbasis
approved these changes
Jun 5, 2023
| @@ -27,7 +27,7 @@ This extension is backwards-compatible, but not part of the initial Engine API. | |||
|
|
|||
| ### ExecutionPayloadV3 | |||
|
|
|||
| This structure has the syntax of `ExecutionPayloadV2` and appends a single field: `excessDataGas`. | |||
| This structure has the syntax of `ExecutionPayloadV2` and append two new fields: `excessDataGas` and `dataGasUsed`. | |||
There was a problem hiding this comment.
Maybe switch order here as well for consistency?
8 tasks
mkalinin
approved these changes
Jun 6, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning Deneb blob spec on these two things:
data_gas_usedfield toExecutionPayloadAdddata_gas_usedfield toExecutionPayloadconsensus-specs#3391ExecutionPayload.excess_data_gastype fromuint256touint64Changeexcess_data_gasanddata_gas_usedtype fromuint256touint64consensus-specs#3392