Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: align WithdrawalRequestV1 with EIP-7002 and consensus spec #549

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nflaig
Copy link
Contributor

@nflaig nflaig commented May 16, 2024

There is an inconsistency between the withdrawal request defined in EIP-7002 (see validator_pubkey field and related PR), the consensus spec (see ExecutionLayerWithdrawalRequest), and the execution api.

This PR align the execution api spec WithdrawalRequestV1 with the other specs.

Most ELs currently return it as validatorPublicKey with the exception of Besu which uses validatorPubKey

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the alignment part but the renaming can cause interop breaks between CL and EL. So we should be careful about when to introduce this change on the client side, at least it should be after devnet-0

@nflaig
Copy link
Contributor Author

nflaig commented May 31, 2024

Do we wanna include this for devnet-1? Might need more visibility on it first, I am not that familiar how you do this on the execution api side but maybe could bring this up in discord and see if there is any opposition to the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants