Electra: field renames #14091
Merged
Electra: field renames #14091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Blocked
james-prysm
commented
Jun 7, 2024
| @@ -25,14 +25,14 @@ func RunExecutionLayerWithdrawalRequestTest(t *testing.T, config string) { | |||
| for _, folder := range testFolders { | |||
| t.Run(folder.Name(), func(t *testing.T) { | |||
| folderPath := path.Join(testsFolderPath, folder.Name()) | |||
| executionLayerWithdrawalRequestFile, err := util.BazelFileBytes(folderPath, "execution_layer_withdrawal_request.ssz_snappy") | |||
| withdrawalRequestFile, err := util.BazelFileBytes(folderPath, "execution_layer_withdrawal_request.ssz_snappy") | |||
There was a problem hiding this comment.
spect test folder should be updated if renamed
james-prysm
added
Ready For Review
testing/spectest/exclusions.txt
Outdated
| @@ -163,7 +163,7 @@ tests/minimal/eip6110/ssz_static/ContributionAndProof | |||
| tests/minimal/eip6110/ssz_static/Deposit | |||
| tests/minimal/eip6110/ssz_static/DepositData | |||
| tests/minimal/eip6110/ssz_static/DepositMessage | |||
| tests/minimal/eip6110/ssz_static/DepositReceipt | |||
There was a problem hiding this comment.
I think you don't want to touch these exclusions until the spectests have been updated. Otherwise the spectest compliance report tool will complain these tests are missing
There was a problem hiding this comment.
will add back in then
terencechain
approved these changes
Jun 12, 2024
prestonvanloon
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
missing
Which issues(s) does this PR fix?
dependent on following PRs merged and released
ethereum/consensus-specs#3757
ethereum/consensus-specs#3791
ethereum/execution-apis#549
ethereum/consensus-specs#3786
Other notes for review