Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filling state test as blockchain makes invalid gas limit #468

Closed
winsvega opened this issue Mar 6, 2024 · 0 comments · Fixed by #472
Closed

filling state test as blockchain makes invalid gas limit #468

winsvega opened this issue Mar 6, 2024 · 0 comments · Fixed by #472

Comments

@winsvega
Copy link
Collaborator

winsvega commented Mar 6, 2024

if I put the gaslimit in the test env to be 12469470
it makes a block#1 with gaslimit 0x016345785d8a0000 which is incorrect.

the test env refers to enviroment of the first block if we filling a state tests in bc form
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this issue Mar 8, 2024
@danceratopz
fix: use parent env's gas limit in current env ethereum#468
92d8076
@danceratopz danceratopz mentioned this issue Mar 8, 2024
Merged
7 tasks
spencer-tb pushed a commit to danceratopz/execution-spec-tests that referenced this issue Mar 9, 2024
@danceratopz @spencer-tb
fix: use parent env's gas limit in current env ethereum#468
8d5de9e
spencer-tb added a commit that referenced this issue Mar 9, 2024
@danceratopz @spencer-tb
bug(fw): fix block header gasLimit value in post genesis blocks for…
c006517 
… blockchain tests (#472)

* fix: use parent env's gas limit in current env #468

* fix(fw): update to include self gas limit.

* chore: add changelog.

---------

Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@winsvega