Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(fw): fix block header gasLimit value in post genesis blocks for blockchain tests #472

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Mar 8, 2024

πŸ—’οΈ Description

Sets the gas_limit block header value to that optionally specified in the genesis_env provided to the blockchain tests constructor, by taking it from the previous env.

πŸ”— Related Issues

Fixes #468.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Mar 8, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment. Thanks!

src/ethereum_test_tools/spec/blockchain/types.py Outdated Show resolved Hide resolved
@spencer-tb spencer-tb force-pushed the fix/incorrect-headers-in-post-genesis-blocks branch from 88e8542 to ccd5395 Compare March 9, 2024 03:31
@spencer-tb spencer-tb changed the title fix(fw): fix block header gasLimit value in post genesis blocks in blockchain tests bug(fw): fix block header gasLimit value in post genesis blocks for blockchain tests Mar 9, 2024
@spencer-tb spencer-tb merged commit c006517 into ethereum:main Mar 9, 2024
5 checks passed
@marioevz marioevz deleted the fix/incorrect-headers-in-post-genesis-blocks branch March 15, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filling state test as blockchain makes invalid gas limit
3 participants