chore: simplify spellcheck setup by combining wordlists #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flake8-spellcheck plugin requires a file called whitelist.txt, this change combines the previous 3 wordlists into one file, so that it 'just works' with flake8. The only disadvantages are that we will: 1. Apply python specific words in whitelist.txt to the markdown spellcheck; not really a big deal. 2. Make it harder to keep track of types of words within the wordlist, e.g., opcodes. As adding a word via the VS Code Cspell interface reorders the dictionary alphabetically; also not such a big deal.
spencer-tb
approved these changes
Aug 24, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change combines the previous 3 wordlists into one file, so that it 'just works' with flake8 (without running an additional script).
The only disadvantages are that we will:
There aren't a big deal though.