Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1153 Transient Storage Tests #230

Merged
merged 28 commits into from Sep 7, 2023
Merged

EIP-1153 Transient Storage Tests #230

merged 28 commits into from Sep 7, 2023

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Jul 27, 2023 •
edited

Adds tests for EIP-1153 Transient storage opcodes, link to discussion on eth-magicians.

Filled with Shanghai (+EIP-1153; enabled in conftest.py), t8n tool used: ethereum/go-ethereum@a196f3e

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Add simple tests for different execution contexts.
    Options
  2. Add simple tests for different creation contexts.
    Options
  3. Remaining EIP-1153 Vectors #291
    3 of 3
    Edit...
  4. Fix xfail: test_reentrant_call[fork=Cancun-invalid_undoes_tstorage_after_successful_call] XFAIL
    Options

@chfast
Copy link
Contributor

chfast commented Aug 23, 2023

What is the status of this?

@danceratopz
Copy link
Member Author

Hi @chfast, picking back up work on this today.

@danceratopz
Copy link
Member Author

Force pushed to include changes from #271; no changes to tests.

@spencer-tb spencer-tb mentioned this pull request Sep 4, 2023
Closed
@danceratopz
tests: add reentrancy tests for tload and tstore
feb4923
@danceratopz
tests: additionally test CALL's return value
666f9cb
@danceratopz
tests: rename create contexts test module
d22a1c4
@danceratopz
tests: minor test execution test improvement
7bae4a3
@danceratopz
tests: rename execution contexts test module
14849e9
@danceratopz
tests: add simple tstorage tests
abeb260
@danceratopz
tests: fix revert_undoes_tstorage_after_successful_cal w/mario
ed72dfc
@danceratopz
tests: remove unused test parameters; mark valid from Cancun
98537eb
@danceratopz
tests: clean-up docstrinsgs; no change to tests
0c86456
@danceratopz
tests: slight improvement to call execution context test
cfb13d8
@danceratopz
tests: fix (very basic) staticcall tests
990c449
@danceratopz
tests: improve delegatecall; add delegatecall with revert test
cb12d90
@danceratopz
tests: fix/improve callcode tests
aa6175a
@danceratopz
tests: mark execution tests valid from Cancun; clean-up ids
8b4843f
@danceratopz
refactor: define pytest_param properly in test case enum
662b1a5
@danceratopz
clean-up: remove unused pytest_param entries in test cases
32a0b1b
marioevz
marioevz reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 💯

Just a few comments of some ideas on how to expand into more tests by adding just a few changes.

Thanks for these!

tests/cancun/eip1153_tstore/test_tstorage_create_contexts.py Show resolved Hide resolved
tests/cancun/eip1153_tstore/test_tstorage_create_contexts.py Show resolved Hide resolved
tests/cancun/eip1153_tstore/test_tstorage_execution_contexts.py Outdated Show resolved Hide resolved
tests/cancun/eip1153_tstore/test_tstorage_execution_contexts.py Outdated Show resolved Hide resolved
tests/cancun/eip1153_tstore/test_tstorage_execution_contexts.py Outdated Show resolved Hide resolved
tests/cancun/eip1153_tstore/test_tstorage_reentrancy_contexts.py Outdated Show resolved Hide resolved
@danceratopz danceratopz marked this pull request as ready for review September 7, 2023 21:01
@danceratopz danceratopz changed the title WIP: EIP-1153 Transient Storage Tests EIP-1153 Transient Storage Tests Sep 7, 2023
marioevz
marioevz approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/cancun/eip1153_tstore/__init__.py Show resolved Hide resolved
@marioevz
Copy link
Member

marioevz commented Sep 7, 2023

Opened #291 so we can follow up on improving the coverage in another PR.

@marioevz marioevz merged commit 2e84395 into ethereum:main Sep 7, 2023
4 checks passed
@danceratopz danceratopz mentioned this pull request Sep 8, 2023
Merged
@marioevz marioevz mentioned this pull request Sep 18, 2023
Closed
@danceratopz danceratopz deleted the tests/1153 branch September 28, 2023 08:22
@marioevz marioevz mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danceratopz @chfast @marioevz