Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/cancun/eip_4788: Update predeploy address(0xbEAC02..7d7a), add additional tests #297

Merged

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Sep 13, 2023

Tagging updates to 4788 from the following PR: ethereum/EIPs#7672

PR Includes

  • Update to the beacon root address & contract bytecode.
  • Additional tests cases:
    • test_invalid_beacon_root_calldata_value - asserts that zero value calldata causes revert.
    • test_beacon_root_selfdestruct - checks that self destructing to the beacon root transfers a balance.

@spencer-tb spencer-tb marked this pull request as ready for review September 19, 2023 14:25
@spencer-tb spencer-tb force-pushed the beacon-root-predeploy-address-update branch from 8ad7f7e to b61f6bd Compare September 19, 2023 14:26
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

If we change the address again, I guess we can make another PR 🙃

@marioevz marioevz changed the title tests/cancun/eip_4788: Update predeploy address & add additional tests tests/cancun/eip_4788: Update predeploy address(0xbEAC02..7d7a), add additional tests Sep 19, 2023
@marioevz marioevz merged commit 805980d into ethereum:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants