improvement: Refactor of spec for blockchain & state test generation

[spencer-tb]

🗒️ Description

The refactor proposal is to use make_fixture() and make_hive_fixture() within fill.py, to abstract all the filling logic to both state_test.py and blockchain_test.py. These additions should make it easier to add the correct StateTest fixture format in the future.

🔗 Related Issues

This is a follow up PR to address some comments on #301.

Resolves the following issue #43.

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[danceratopz]

Rebased onto main following the merge of #322 (#322 used a squash commit).

[danceratopz]

Nice, looks cleaner to me!

Nice to see engine / "NoProof" removed from the pytest interface... that seemed unnecessary back when we did the pytest port.

[marioevz]

I really like the changes, I'd like to diff the fixtures against the ones currently generated on main, just to double check we are not breaking anything :)

[danceratopz]

I really like the changes, I'd like to diff the fixtures against the ones currently generated on main, just to double check we are not breaking anything :)

I diff'd 52f8514.

• Without --enable-hive: The only differences I see are changes in fixture names (as mentioned above).
• With --enable-hive: Also differences in names. Only other difference is the presence of engineFcuVersion where it was previously missing (presumably a good thing? :))

diff '--color=auto' -r fixtures-geth-main-hive-ordered/shanghai/eip4895_withdrawals/withdrawals/use_value_in_tx.json fixtures-refactor-spec-hive-ordered/shanghai/eip4895_withdrawals/withdrawals/use_value_in_tx.json
7a8
>         "engineFcuVersion": "2",
187a189
>         "engineFcuVersion": "3",

[danceratopz]

LGTM!

I decided not to use nodeid for fixture names in JSON within the scope of this PR, and created a ticket instead, see:

• The comment in this PR for more info: improvement: Refactor of spec for blockchain & state test generation #307 (comment)
• Follow-up issue: feat(fw): use pytest nodeids as test names in json fixtures #329