-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tools): update invalid blockchain fixture format #322
feat(tools): update invalid blockchain fixture format #322
Conversation
0b3dc3e
to
cd25737
Compare
Tested with the geth t8n; after concerneds where addressed in the issue referenced above. This was achieved by running |
cd25737
to
a11b7b1
Compare
Note that #307 is rebased onto this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would appreciate a second check from someone else.
src/ethereum_test_tools/tests/test_fixtures/blockchain_london_invalid_filled.json
Show resolved
Hide resolved
Co-authored-by: Dan <danceratopz@gmail.com>
I've doubled checked this today - we don't need the
And hence duplicated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🗒️ Description
Updates the format for invalid blocks in the default fixture. Currently evmone can't consume RLP. The PR provides an alternative way for them and others to consume invalid blocks generated by tests.
The new proposed invalid
block
format is the following:🔗 Related Issues
The new format was initially flagged here: ethereum/tests#1293.
Tagging @rodiazet and @winsvega.
✅ Checklist