Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw): calculate genesis state root without calling t8n #450

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Feb 21, 2024

πŸ—’οΈ Description

Removes the call to t8n to calculate the state root of the genesis block for blockchain tests, and in its place it uses the execution-specs routine to fill the state and calculate the root.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega
Copy link
Collaborator

oh, that should speed up the process significantly.
as each test has the call, but now you have to maintain the state calculation.

@marioevz marioevz added type:refactor Type: Refactor type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Feb 22, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! πŸ™‚ We need to fix up the docs for --evm-dump-dir
https://ethereum.github.io/execution-spec-tests/v2.1.0/getting_started/debugging_t8n_tools/#evm-dump-directory.

I don't mind doing it; I'm just heading offline and noting here quickly before I forget.

@marioevz
Copy link
Member Author

Requested change done @danceratopz πŸ˜‰

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really like the use of ethereum.base_types!

@marioevz marioevz merged commit 0f67b6c into ethereum:main Feb 28, 2024
5 checks passed
@marioevz marioevz deleted the remove-calc-state-root branch February 28, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants