Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pytest-filler): Remove collected items without parametrized fork #452

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Feb 22, 2024

🗒️ Description

There's some instances where a test function in a module ends up being skipped and the parametrized fork contains a None value which then triggers an exception in function pytest_collection_modifyitems of test_filler.py.

This PR modifies behavior so that the item is removed if it reaches the pytest_collection_modifyitems without a fork value.

Example fill command:

fill -vv --fork=Prague tests/cancun/eip7516_blobgasfee/test_blobgasfee_opcode.py

fails before this PR.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:evm Scope: evm_transition_tool package scope:pytest Scope: Pytest plugins labels Feb 22, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit e755777 into ethereum:main Feb 28, 2024
5 checks passed
@marioevz marioevz deleted the fix-forkless-item-collection branch February 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:evm Scope: evm_transition_tool package scope:pytest Scope: Pytest plugins type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants