Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fw): augment & use Fixtures model in fixture collection #508

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Apr 14, 2024

πŸ—’οΈ Description

This is a gentle refactor to make use of Fixtures during fixture collection and writing:

  • Moves collect_info_file() from the BaseFixture class to Fixtures. It now also takes a file instead of an fd for consistency with other Fixtures methods.
  • Use Fixtures model in the FixtureCollector class.

πŸ”— Related Issues

Makes use of #501.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:refactor Type: Refactor scope:fw Scope: Framework (evm|tools|forks|pytest) labels Apr 14, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 4e66cef into main Apr 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants