Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: soften package requirements for compatibility with other dependences #510

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Apr 16, 2024

🗒️ Description

This PR:

  • Softens minor and patch package dependency version requirements to try to avoid dependency conflicts with other dependencies (as we're currently experiencing, this is described in more details below).
  • Sharpens major package requirements to avoid potential incompatibilities if one of our dependencies releases a new major version.

ethereum/execution-specs just bumped their consensus-specs dependency which in turn now requires py-trie v2.0.2. We currently require trie v2.1.1:

install_requires =
ethereum@git+https://github.com/ethereum/execution-specs.git
setuptools
types-setuptools
requests>=2.31.0
colorlog>=6.7.0
pytest==7.3.2
pytest-xdist>=3.3.1,<4
coincurve>=18.0.0,<19
trie==2.1.1

This leads to a version conflict and installing ethereum-execution-specs fails with:

  INFO: pip is looking at multiple versions of eth2spec to determine which version is compatible with other requirements. This could take a while.

The conflict is caused by:
    The user requested trie==2.1.1
    eth2spec 1.4.0b7 depends on trie==2.0.2

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
...
ERROR: Cannot install ethereum and trie==2.1.1 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
...
tests: FAIL ✖ in 19.8 seconds

ethereum/execution-specs@caa1b1b

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:ci Scope: Continuous Integration type:chore Type: Chore labels Apr 16, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM :)

@danceratopz danceratopz merged commit 3a6520e into main Apr 16, 2024
9 checks passed
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this pull request Apr 16, 2024
danceratopz added a commit to ipsilon/execution-spec-tests that referenced this pull request Apr 16, 2024
Required to resolve a dependency conflict with upstream dependency, cf ethereum#510.
@marioevz marioevz deleted the chore/use-compatible-trie-package-version branch May 3, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants